From: David Miller <davem@davemloft.net>
To: ying.xue@windriver.com
Cc: netdev@vger.kernel.org, jbenc@redhat.com, fengguang.wu@intel.com,
kbuild-all@01.org
Subject: Re: [PATCH RESEND net-next] lwtunnel: Fix the sparse warnings in fib_encap_match
Date: Wed, 19 Aug 2015 17:39:06 -0700 (PDT) [thread overview]
Message-ID: <20150819.173906.397363174611794943.davem@davemloft.net> (raw)
In-Reply-To: <1439970377-13032-1-git-send-email-ying.xue@windriver.com>
From: Ying Xue <ying.xue@windriver.com>
Date: Wed, 19 Aug 2015 15:46:17 +0800
> When CONFIG_LWTUNNEL config is not enabled, the lwtstate_free() is not
> declared in lwtunnel.h at all. However, even in this case, the function
> is still referenced in fib_semantics.c so that there appears the
> following sparse warnings:
>
> net/ipv4/fib_semantics.c:553:17: error: undefined identifier 'lwtstate_free'
> CC net/ipv4/fib_semantics.o
> net/ipv4/fib_semantics.c: In function ‘fib_encap_match’:
> net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function ‘lwtstate_free’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [net/ipv4/fib_semantics.o] Error 1
> make: *** [net/ipv4/fib_semantics.o] Error 2
>
> To eliminate the error, we define an empty function for lwtstate_free()
> in lwtunnel.h when CONFIG_LWTUNNEL is disabled.
>
> Fixes: df383e6240ef ("lwtunnel: fix memory leak")
> Cc: Jiri Benc <jbenc@redhat.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> Acked-by: Jiri Benc <jbenc@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2015-08-20 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 7:46 [PATCH RESEND net-next] lwtunnel: Fix the sparse warnings in fib_encap_match Ying Xue
2015-08-20 0:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819.173906.397363174611794943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=jbenc@redhat.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).