From: Jiri Benc <jbenc@redhat.com>
To: Tom Herbert <tom@herbertland.com>
Cc: <davem@davemloft.net>, <roopa@cumulusnetworks.com>,
<netdev@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH net-next 1/2] lwt: Add cfg argumnt to build_state
Date: Wed, 19 Aug 2015 12:52:11 +0200 [thread overview]
Message-ID: <20150819125211.7d2afcaa@griffin> (raw)
In-Reply-To: <1439954471-599831-2-git-send-email-tom@herbertland.com>
On Tue, 18 Aug 2015 20:21:10 -0700, Tom Herbert wrote:
> diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h
> index e25b60e..9bf7e6a 100644
> --- a/include/net/lwtunnel.h
> +++ b/include/net/lwtunnel.h
> @@ -26,7 +26,8 @@ struct lwtunnel_state {
>
> struct lwtunnel_encap_ops {
> int (*build_state)(struct net_device *dev, struct nlattr *encap,
> - struct lwtunnel_state **ts);
> + struct lwtunnel_state **ts,
> + unsigned int family, const void *cfg);
Could you please keep the output parameter as the last one?
(It might be better if build_state returned the newly allocated struct
instead and used pointer encoded errors but that's for a different
patch.)
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-08-19 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 3:21 [PATCH net-next 0/2] ila: Precompute checksums Tom Herbert
2015-08-19 3:21 ` [PATCH net-next 1/2] lwt: Add cfg argumnt to build_state Tom Herbert
2015-08-19 10:52 ` Jiri Benc [this message]
2015-08-19 3:21 ` [PATCH net-next 2/2] ila: Precompute checksum difference for translations Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819125211.7d2afcaa@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).