From: Jiri Benc <jbenc@redhat.com>
To: Vincent Bernat <vincent@bernat.im>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs
Date: Wed, 19 Aug 2015 13:00:13 +0200 [thread overview]
Message-ID: <20150819130013.1a847627@griffin> (raw)
In-Reply-To: <1439966648-26195-2-git-send-email-vincent@bernat.im>
On Wed, 19 Aug 2015 08:44:08 +0200, Vincent Bernat wrote:
> While the documentation doesn't say exactly what kind of relationship
> iflink should represent, until a45253, only lower devices were
> advertised this way. While veth cannot have a lower device, using iflink
> to advertise the peer may create infinite loops in programs using iflink
> to discover device topology.
>
> Instead of advertising the peer link with iflink, a symbolic link "peer"
> is added to each peer.
By removing veth_get_iflink, you're also stopping IFLA_LINK being
advertised in netlink messages, which consequently makes impossible to
reliably match veth peers across name spaces again. This would be a
huge step backwards.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-08-19 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fv3ier4s.fsf@zoro.exoscale.ch>
2015-08-19 6:44 ` Regression in 4.1 with veth and IFLA_LINK Vincent Bernat
2015-08-19 6:44 ` [PATCH] veth: replace iflink by a dedicated symlink in sysfs Vincent Bernat
2015-08-19 11:00 ` Jiri Benc [this message]
2015-08-19 12:13 ` Vincent Bernat
2015-08-19 12:38 ` Jiri Benc
2015-08-19 12:48 ` Vincent Bernat
2015-08-19 16:33 ` Nicolas Dichtel
2015-08-20 11:53 ` Jiri Benc
2015-08-20 14:31 ` Nicolas Dichtel
2015-08-20 21:07 ` David Miller
2015-08-22 20:51 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819130013.1a847627@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).