From: Corinna Vinschen <vinschen@redhat.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>, Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters
Date: Wed, 19 Aug 2015 15:07:44 +0200 [thread overview]
Message-ID: <20150819130744.GA24832@calimero.vinschen.de> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2F4BF49@RTITMBSV03.realtek.com.tw>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Aug 19 09:31, Hayes Wang wrote:
> Corinna Vinschen [mailto:vinschen@redhat.com]
> > Sent: Wednesday, August 19, 2015 5:13 PM
> [...]
> > > It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152.
> >
> > Is it safe to assume that this is implemented in all NICs covered by r8169?
>
> It is supported from RTL8111C. That is, RTL_GIGA_MAC_VER_19 and later.
Thanks. In that case I would prefer the same generic method for all
chip versions, so I'd opt for storing the offset values at rtl_open
time as my patch is doing right now. Is that acceptable?
If so, wouldn't it make even more sense to use the hardware collected
information in @get_stats64 throughout, except for the numbers collected
*only* in software?
I would be willing to propose a matching patch.
Thanks,
Corinna
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-19 13:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:04 [PATCH] r8169: Add values missing in @get_stats64 from HW counters Corinna Vinschen
2015-08-18 21:40 ` Francois Romieu
2015-08-19 2:05 ` David Miller
2015-08-19 9:10 ` Corinna Vinschen
2015-08-19 2:51 ` Hayes Wang
2015-08-19 9:13 ` Corinna Vinschen
2015-08-19 9:31 ` Hayes Wang
2015-08-19 13:07 ` Corinna Vinschen [this message]
2015-08-19 14:24 ` Corinna Vinschen
2015-08-19 19:24 ` Corinna Vinschen
2015-08-20 2:43 ` Hayes Wang
2015-08-20 9:41 ` Corinna Vinschen
2015-08-20 9:56 ` Hayes Wang
2015-08-21 10:09 ` [PATCH v2 net-next] " Corinna Vinschen
2015-08-21 10:24 ` Corinna Vinschen
2015-08-21 19:39 ` Francois Romieu
2015-08-21 22:07 ` Corinna Vinschen
2015-08-21 23:59 ` Francois Romieu
2015-08-22 8:39 ` Corinna Vinschen
2015-08-22 11:23 ` Francois Romieu
2015-08-24 7:33 ` Corinna Vinschen
2015-08-24 10:29 ` Corinna Vinschen
2015-08-24 23:33 ` Francois Romieu
2015-08-25 8:39 ` Corinna Vinschen
2015-08-25 21:14 ` Francois Romieu
2015-08-24 10:27 ` [PATCH v3 " Corinna Vinschen
2015-08-24 10:52 ` [PATCH v4 " Corinna Vinschen
2015-08-25 21:15 ` David Miller
2015-08-25 22:54 ` Francois Romieu
2015-08-25 22:59 ` David Miller
2015-08-25 23:03 ` David Miller
2015-08-26 8:55 ` Corinna Vinschen
2015-08-26 8:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819130744.GA24832@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=hayeswang@realtek.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).