From: Phil Sutter <phil@nwl.cc>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, brouer@redhat.com, davem@davemloft.net
Subject: Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0
Date: Wed, 19 Aug 2015 23:04:43 +0200 [thread overview]
Message-ID: <20150819210409.C5BF82137D@mail.nwl.cc> (raw)
In-Reply-To: <1440016420.6610.29.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Aug 19, 2015 at 01:33:40PM -0700, Eric Dumazet wrote:
> On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote:
>
> > lpaa5:~# tc qd sh dev eth1
> > qdisc mq 0: root
> > qdisc fq 0: parent :4 limit 10000p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140
> > qdisc fq 0: parent :3 limit 10000p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140
> > qdisc fq 0: parent :2 limit 10000p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140
> > qdisc fq 0: parent :1 limit 10000p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140
>
> Well, it seems I just leaked fact that we use 3-bands in our fq
> implementation ;)
The problem with subtle details is they cease to be if pointed out. In
another episode I was about to ask who the ominous "we" are, but then I
noticed your mail's message ID. :)
Cheers, Phil
next prev parent reply other threads:[~2015-08-19 21:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 8:30 [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards Phil Sutter
2015-08-18 8:30 ` [PATCH 01/21] net: veth: enable noqueue operation by default Phil Sutter
2015-08-18 8:30 ` [PATCH 02/21] net: dummy: convert to using IFF_NO_QUEUE Phil Sutter
2015-08-18 8:30 ` [PATCH 03/21] net: geneve: " Phil Sutter
2015-08-18 8:30 ` [PATCH 04/21] net: loopback: " Phil Sutter
2015-08-18 8:30 ` [PATCH 05/21] net: nlmon: " Phil Sutter
2015-08-18 8:30 ` [PATCH 06/21] net: team: " Phil Sutter
2015-08-18 8:30 ` [PATCH 07/21] net: vxlan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 08/21] net: 8021q: " Phil Sutter
2015-08-18 8:30 ` [PATCH 09/21] net: bridge: " Phil Sutter
2015-08-18 8:30 ` [PATCH 10/21] net: 6lowpan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 11/21] net: bonding: " Phil Sutter
2015-08-18 8:30 ` [PATCH 12/21] net: ipvlan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 13/21] net: dsa: " Phil Sutter
2015-08-18 8:30 ` [PATCH 14/21] net: hostap: " Phil Sutter
2015-08-18 8:30 ` [PATCH 15/21] net: mac80211_hwsim: " Phil Sutter
2015-08-18 8:30 ` [PATCH 16/21] net: batman-adv: " Phil Sutter
2015-08-18 8:30 ` [PATCH 17/21] net: hsr: " Phil Sutter
2015-08-18 8:30 ` [PATCH 18/21] net: caif: " Phil Sutter
2015-08-18 8:30 ` [PATCH 19/21] staging: wilc1000: " Phil Sutter
2015-08-18 8:30 ` [PATCH 20/21] net: warn if drivers set tx_queue_len = 0 Phil Sutter
2015-08-18 8:30 ` [PATCH 21/21] net: sched: drop all special handling of tx_queue_len == 0 Phil Sutter
2015-08-18 14:47 ` [PATCH 20/21] net: warn if drivers set tx_queue_len = 0 Eric Dumazet
2015-08-18 18:14 ` Phil Sutter
2015-08-19 18:39 ` Phil Sutter
2015-08-19 20:21 ` Phil Sutter
2015-08-19 20:31 ` Eric Dumazet
2015-08-19 20:33 ` Eric Dumazet
2015-08-19 21:04 ` Phil Sutter [this message]
2015-08-18 8:43 ` [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE Johannes Berg
2015-08-18 18:54 ` David Miller
2015-08-18 18:56 ` [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819210409.C5BF82137D@mail.nwl.cc \
--to=phil@nwl.cc \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).