From: David Miller <davem@davemloft.net>
To: b38611@freescale.com
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board
Date: Thu, 20 Aug 2015 14:05:31 -0700 (PDT) [thread overview]
Message-ID: <20150820.140531.1320709021949935376.davem@davemloft.net> (raw)
In-Reply-To: <1439962444-27486-1-git-send-email-b38611@freescale.com>
From: Fugang Duan <b38611@freescale.com>
Date: Wed, 19 Aug 2015 13:33:58 +0800
> The patch series is to add fec support for i.MX7d sdb board. Since i.MX7d fec ip is
> the same as i.MX6SX, so there have no change for driver itself.
>
> Patch#1: add bcm54220 PHY ID entry into brcmphy.h file.
This is completely, and utterly, pointless.
The only reason a PHY ID should be defined in brcmphy.h is so that it can
be used in the broadcom.c PHY driver or similar.
If there is no user in the tree, there is no reason to add it to the
header file.
next prev parent reply other threads:[~2015-08-20 21:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 5:33 [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board Fugang Duan
2015-08-19 5:33 ` [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID Fugang Duan
2015-08-19 21:28 ` Florian Fainelli
2015-08-20 1:16 ` Duan Andy
2015-08-19 5:34 ` [PATCH v1 2/6] ARM: imx7d: add imx7d iomux-gpr field define Fugang Duan
2015-08-19 5:34 ` [PATCH v1 3/6] ARM: imx: add enet init for i.MX7D platform Fugang Duan
2015-08-19 5:34 ` [PATCH v1 4/6] ARM: dts: imx: pinfunc: add GPIO1 pin define for i.MX7d Fugang Duan
2015-08-19 5:34 ` [PATCH v1 5/6] ARM: dts: imx7d: add fec1 and fec2 support for i.MX7d soc Fugang Duan
2015-08-19 5:34 ` [PATCH v1 6/6] ARM: dts: imx7d-sdb: add fec1 and fec2 support Fugang Duan
2015-08-20 21:05 ` David Miller [this message]
2015-08-20 21:14 ` [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board Florian Fainelli
2015-08-21 23:48 ` Duan Andy
2015-08-21 23:49 ` Duan Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820.140531.1320709021949935376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b38611@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).