From: David Miller <davem@davemloft.net>
To: izumi.taku@jp.fujitsu.com
Cc: netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org,
dvhart@infradead.org, rkhan@redhat.com,
alexander.h.duyck@redhat.com, linux-acpi@vger.kernel.org,
joe@perches.com, sergei.shtylyov@cogentembedded.com,
stephen@networkplumber.org, yasu.isimatu@gmail.com
Subject: Re: [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver
Date: Thu, 20 Aug 2015 15:49:01 -0700 (PDT) [thread overview]
Message-ID: <20150820.154901.1696097888673162441.davem@davemloft.net> (raw)
In-Reply-To: <1440060386-13189-1-git-send-email-izumi.taku@jp.fujitsu.com>
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
Date: Thu, 20 Aug 2015 17:46:05 +0900
> +obj-$(CONFIG_FUJITSU_ES) += fjes.o
> +
> +fjes-objs := fjes_main.o
> +
Please do not have trailing empty lines in any files you add
or edit, 'git' warns about this even when applying patches.
> +static int fjes_acpi_add(struct acpi_device *device)
> +{
> + acpi_status status;
> + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL};
> + union acpi_object *str;
> + char str_buf[sizeof(FJES_ACPI_SYMBOL) + 1];
> + int result;
> + struct platform_device *plat_dev;
Please order your local variables in "reverse christmas tree" order, which
means longer lines come before shorter ones.
Please correct this problem in your entire submission, as I am not going
to point out each and every other place where this problem exists.
next prev parent reply other threads:[~2015-08-20 22:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 8:45 [PATCH v2.2 00/22] FUJITSU Extended Socket network device driver Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 02/22] fjes: Hardware initialization routine Taku Izumi
2015-08-20 22:49 ` David Miller
2015-08-20 8:46 ` [PATCH v2.2 03/22] fjes: Hardware cleanup routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine Taku Izumi
2015-08-20 22:51 ` David Miller
2015-08-20 8:46 ` [PATCH v2.2 05/22] fjes: ES information acquisition routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 06/22] fjes: buffer address regist/unregistration routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 07/22] fjes: net_device_ops.ndo_open and .ndo_stop Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 08/22] fjes: net_device_ops.ndo_start_xmit Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 09/22] fjes: raise_intr_rxdata_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 10/22] fjes: tx_stall_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 11/22] fjes: NAPI polling function Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 12/22] fjes: net_device_ops.ndo_get_stats64 Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 13/22] fjes: net_device_ops.ndo_change_mtu Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 14/22] fjes: net_device_ops.ndo_tx_timeout Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 16/22] fjes: interrupt_watch_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 17/22] fjes: force_close_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 18/22] fjes: unshare_watch_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 19/22] fjes: update_zone_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 20/22] fjes: epstop_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 21/22] fjes: handle receive cancellation request interrupt Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 22/22] fjes: ethtool support Taku Izumi
2015-08-20 22:49 ` David Miller [this message]
2015-08-21 6:11 ` [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver Izumi, Taku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820.154901.1696097888673162441.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@redhat.com \
--cc=dvhart@infradead.org \
--cc=izumi.taku@jp.fujitsu.com \
--cc=joe@perches.com \
--cc=linux-acpi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rkhan@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).