From: David Miller <davem@davemloft.net>
To: izumi.taku@jp.fujitsu.com
Cc: netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org,
dvhart@infradead.org, rkhan@redhat.com,
alexander.h.duyck@redhat.com, linux-acpi@vger.kernel.org,
joe@perches.com, sergei.shtylyov@cogentembedded.com,
stephen@networkplumber.org, yasu.isimatu@gmail.com
Subject: Re: [PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine
Date: Thu, 20 Aug 2015 15:51:28 -0700 (PDT) [thread overview]
Message-ID: <20150820.155128.302382371842900422.davem@davemloft.net> (raw)
In-Reply-To: <1440060386-13189-4-git-send-email-izumi.taku@jp.fujitsu.com>
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
Date: Thu, 20 Aug 2015 17:46:08 +0900
> +
> +err_register:
> + fjes_hw_exit(&adapter->hw);
> +err_hw_init:
> +err_sw_init:
> + free_netdev(netdev);
> +err_alloc_netdev:
> + return err;
Having multiple code labels in the same exact spot is suboptimal.
Instead, name the labels such that they describe the first cleanup
action they will perform, instead of the context in which they are
jumped to from.
So "err_hw_exit:", "err_free_netdev", and "err_out:" would be
appropriate.
next prev parent reply other threads:[~2015-08-20 22:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 8:45 [PATCH v2.2 00/22] FUJITSU Extended Socket network device driver Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 02/22] fjes: Hardware initialization routine Taku Izumi
2015-08-20 22:49 ` David Miller
2015-08-20 8:46 ` [PATCH v2.2 03/22] fjes: Hardware cleanup routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine Taku Izumi
2015-08-20 22:51 ` David Miller [this message]
2015-08-20 8:46 ` [PATCH v2.2 05/22] fjes: ES information acquisition routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 06/22] fjes: buffer address regist/unregistration routine Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 07/22] fjes: net_device_ops.ndo_open and .ndo_stop Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 08/22] fjes: net_device_ops.ndo_start_xmit Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 09/22] fjes: raise_intr_rxdata_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 10/22] fjes: tx_stall_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 11/22] fjes: NAPI polling function Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 12/22] fjes: net_device_ops.ndo_get_stats64 Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 13/22] fjes: net_device_ops.ndo_change_mtu Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 14/22] fjes: net_device_ops.ndo_tx_timeout Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 16/22] fjes: interrupt_watch_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 17/22] fjes: force_close_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 18/22] fjes: unshare_watch_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 19/22] fjes: update_zone_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 20/22] fjes: epstop_task Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 21/22] fjes: handle receive cancellation request interrupt Taku Izumi
2015-08-20 8:46 ` [PATCH v2.2 22/22] fjes: ethtool support Taku Izumi
2015-08-20 22:49 ` [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver David Miller
2015-08-21 6:11 ` Izumi, Taku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820.155128.302382371842900422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@redhat.com \
--cc=dvhart@infradead.org \
--cc=izumi.taku@jp.fujitsu.com \
--cc=joe@perches.com \
--cc=linux-acpi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rkhan@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).