From: Jiri Benc <jbenc@redhat.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Vincent Bernat <vincent@bernat.im>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs
Date: Thu, 20 Aug 2015 13:53:07 +0200 [thread overview]
Message-ID: <20150820135307.3ce12f69@griffin> (raw)
In-Reply-To: <55D4AFCA.7080300@6wind.com>
On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote:
> Probably better to introduce veth netlink attribute then, something like
> IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID.
I'd prefer IFLA_PEER. More generic attribute will be helpful should we
introduce an interface similar to veth in the future.
Also, I'd not combine IFLA_LINK_NETNSID with IFLA_PEER. There might
very well be an interface in the future that will need both IFLA_LINK and
IFLA_PEER and this would just create a confusion. It may be unlikely
but the attributes are cheap and it doesn't make sense to design uAPI
in a way that might bring problems in the future.
> I also don't know what is the best way to handle this. veth advertises
> its peer via IFLA_LINK since 4.1, so it's too late to change it for this
> release.
Apparently we need to pick our poison. Either way, we break something.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-08-20 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fv3ier4s.fsf@zoro.exoscale.ch>
2015-08-19 6:44 ` Regression in 4.1 with veth and IFLA_LINK Vincent Bernat
2015-08-19 6:44 ` [PATCH] veth: replace iflink by a dedicated symlink in sysfs Vincent Bernat
2015-08-19 11:00 ` Jiri Benc
2015-08-19 12:13 ` Vincent Bernat
2015-08-19 12:38 ` Jiri Benc
2015-08-19 12:48 ` Vincent Bernat
2015-08-19 16:33 ` Nicolas Dichtel
2015-08-20 11:53 ` Jiri Benc [this message]
2015-08-20 14:31 ` Nicolas Dichtel
2015-08-20 21:07 ` David Miller
2015-08-22 20:51 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820135307.3ce12f69@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).