From: Thomas Graf <tgraf@suug.ch>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/9] geneve: Use skb mark and protocol to lookup route.
Date: Thu, 20 Aug 2015 18:47:27 +0200 [thread overview]
Message-ID: <20150820164727.GA8475@pox.localdomain> (raw)
In-Reply-To: <1439845905-31666-3-git-send-email-pshelar@nicira.com>
On 08/17/15 at 02:11pm, Pravin B Shelar wrote:
> On packet transmit path geneve need to lookup route. Following
> patch improves route lookup using more parameters.
>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> ---
> drivers/net/geneve.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 51f7f8b..4f4d15e 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -202,6 +202,9 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, struct net_device *dev)
> memset(&fl4, 0, sizeof(fl4));
> fl4.flowi4_tos = RT_TOS(tos);
> fl4.daddr = geneve->remote.sin_addr.s_addr;
> + fl4.flowi4_mark = skb->mark;
> + fl4.flowi4_proto = IPPROTO_UDP;
Looks like it's time to add a helper for this so we don't lag behind
in specifying flowi parameters in various lookup sites all the time.
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-08-20 16:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 21:11 [PATCH net-next v2 0/9] Geneve: Add support for tunnel metadata mode Pravin B Shelar
2015-08-17 21:11 ` [PATCH net-next v2 1/9] geneve: Initialize ethernet address in device setup Pravin B Shelar
2015-08-19 0:10 ` Jesse Gross
2015-08-20 16:47 ` Thomas Graf
2015-08-17 21:11 ` [PATCH net-next v2 2/9] geneve: Use skb mark and protocol to lookup route Pravin B Shelar
2015-08-19 0:12 ` Jesse Gross
2015-08-20 16:47 ` Thomas Graf [this message]
2015-08-17 21:11 ` [PATCH net-next v2 3/9] tunnel: introduce udp_tun_rx_dst() Pravin B Shelar
2015-08-20 16:56 ` Thomas Graf
2015-08-20 20:36 ` Pravin Shelar
2015-08-17 21:11 ` [PATCH net-next v2 4/9] geneve: Make dst-port configurable Pravin B Shelar
2015-08-19 0:27 ` Jesse Gross
2015-08-20 16:58 ` Thomas Graf
2015-08-17 21:11 ` [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata Pravin B Shelar
2015-08-18 21:12 ` David Miller
2015-08-20 20:33 ` Pravin Shelar
2015-08-19 1:07 ` Jesse Gross
2015-08-20 20:31 ` Pravin Shelar
2015-08-17 21:11 ` [PATCH net-next v2 6/9] openvswitch: Use Geneve device Pravin B Shelar
2015-08-17 21:11 ` [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module Pravin B Shelar
2015-08-19 18:18 ` Jesse Gross
2015-08-19 18:29 ` Pravin Shelar
2015-08-19 18:37 ` Jesse Gross
2015-08-19 18:49 ` Pravin Shelar
2015-08-19 19:50 ` Jesse Gross
2015-08-19 20:14 ` Pravin Shelar
2015-08-17 21:11 ` [PATCH net-next v2 8/9] geneve: Move device hash table to geneve socket Pravin B Shelar
2015-08-19 19:05 ` Jesse Gross
2015-08-17 21:11 ` [PATCH net-next v2 9/9] geneve: Implement rtnl changelink Pravin B Shelar
2015-08-19 19:40 ` Jesse Gross
2015-08-19 20:12 ` Pravin Shelar
2015-08-19 22:39 ` Jesse Gross
2015-08-20 20:33 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820164727.GA8475@pox.localdomain \
--to=tgraf@suug.ch \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).