* [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback
@ 2015-08-19 22:54 Vivien Didelot
2015-08-23 22:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vivien Didelot @ 2015-08-19 22:54 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Guenter Roeck, Andrew Lunn,
Florian Fainelli, Vivien Didelot
The current Secure port mode requires the port-based VLANs to also be
valid in the 802.1Q VLAN Table Unit. The current hardware bridging
support only configures the port-based VLANs, thus is broken.
A new patchset is required to adapt the hardware bridging code to fully
support the Secure port mode.
In the meantime, change the 802.1Q mode of every ports to Fallback,
which filtering is more permissive, and doesn't add this restriction to
handle port-based and tagged-based VLANs.
Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index dee71fa..91d7e0a 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2091,7 +2091,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
}
- reg |= PORT_CONTROL_2_8021Q_SECURE;
+ reg |= PORT_CONTROL_2_8021Q_FALLBACK;
if (reg) {
ret = _mv88e6xxx_reg_write(ds, REG_PORT(port),
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback
2015-08-19 22:54 [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback Vivien Didelot
@ 2015-08-23 22:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-08-23 22:54 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, linux, andrew, f.fainelli
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Wed, 19 Aug 2015 18:54:55 -0400
> The current Secure port mode requires the port-based VLANs to also be
> valid in the 802.1Q VLAN Table Unit. The current hardware bridging
> support only configures the port-based VLANs, thus is broken.
>
> A new patchset is required to adapt the hardware bridging code to fully
> support the Secure port mode.
>
> In the meantime, change the 802.1Q mode of every ports to Fallback,
> which filtering is more permissive, and doesn't add this restriction to
> handle port-based and tagged-based VLANs.
>
> Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-23 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 22:54 [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback Vivien Didelot
2015-08-23 22:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).