From: Jiri Pirko <jiri@resnulli.us>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jiri Pirko <jiri@mellanox.com>,
kernel-janitors@vger.kernel.org,
Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/11] mlxsw: fix error return code
Date: Sun, 23 Aug 2015 20:52:26 +0200 [thread overview]
Message-ID: <20150823185226.GA2396@nanopsycho.orion> (raw)
In-Reply-To: <1440288682-12732-6-git-send-email-Julia.Lawall@lip6.fr>
Sun, Aug 23, 2015 at 02:11:16AM CEST, Julia.Lawall@lip6.fr wrote:
>Return a negative error code on failure.
>
>A simplified version of the semantic match that finds this problem is as
>follows: (http://coccinelle.lip6.fr/)
>
>// <smpl>
>@@
>identifier ret; expression e1,e2;
>@@
>(
>if (\(ret < 0\|ret != 0\))
> { ... return ret; }
>|
>ret = 0
>)
>... when != ret = e1
> when != &ret
>*if(...)
>{
> ... when != ret = e2
> when forall
> return ret;
>}
>// </smpl>
>
>Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2015-08-23 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 0:11 [PATCH 00/11] fix error return code Julia Lawall
2015-08-23 0:11 ` [PATCH 03/11] net: davinci_emac: " Julia Lawall
2015-08-25 20:39 ` David Miller
2015-08-23 0:11 ` [PATCH 05/11] mlxsw: " Julia Lawall
2015-08-23 18:52 ` Jiri Pirko [this message]
2015-08-25 20:39 ` David Miller
2015-08-23 0:11 ` [PATCH 10/11] ah6: " Julia Lawall
2015-08-24 12:13 ` Herbert Xu
2015-08-25 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150823185226.GA2396@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=Julia.Lawall@lip6.fr \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).