From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
eric.dumazet@gmail.com, brouer@redhat.com
Subject: Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc
Date: Sun, 23 Aug 2015 20:53:57 +0200 [thread overview]
Message-ID: <20150823205357.5df72804@redhat.com> (raw)
In-Reply-To: <20150823204442.2e032436@redhat.com>
On Sun, 23 Aug 2015 20:44:42 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> On Sat, 22 Aug 2015 02:20:56 +0200
> Phil Sutter <phil@nwl.cc> wrote:
>
> > When removing the root qdisc, the interface should fall back to noqueue
> > as the 'real' minimal qdisc instead of the default one.
>
> I worry this behavior could break existing scripts.
You would break OpenWRT package "qos-scripts", specifically:
https://github.com/openwrt-mirror/openwrt/blob/master/package/network/config/qos-scripts/files/usr/bin/qos-stop
Which cleans-up/clear the qdisc setup by removing the root qdisc,
assuming and depending on the default qdisc is re-assigned.
> I prefer the idea of allowing tc command to assign noqueue (to any
> device). This makes the action explicit for the user, instead of being
> a side-effect of removing a qdisc. (and does not break backward compat)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2015-08-23 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 0:20 [net-next PATCH v2 0/3] net: sched: allow switching qdisc to noqueue intuitively Phil Sutter
2015-08-22 0:20 ` [net-next PATCH v2 1/3] net: sched: make noqueue_qdisc non-static Phil Sutter
2015-08-22 0:20 ` [net-next PATCH v2 2/3] net: sched: allocate a handle to default qdiscs Phil Sutter
2015-08-22 0:20 ` [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc Phil Sutter
2015-08-23 18:44 ` Jesper Dangaard Brouer
2015-08-23 18:53 ` Jesper Dangaard Brouer [this message]
2015-08-26 9:48 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150823205357.5df72804@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).