From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING Date: Mon, 24 Aug 2015 10:01:46 -0300 Message-ID: <20150824130146.GA1097@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , tgraf@infradead.org, davem@davemloft.net To: Xin Long Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49531 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbbHXNBs (ORCPT ); Mon, 24 Aug 2015 09:01:48 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Aug 23, 2015 at 07:30:40PM +0800, Xin Long wrote: > when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING state, > if B neither claim his rwnd is 0 nor send SACK for this data, A will keep > retransmitting this data util t5 timeout, Max.Retrans times can't work anymore, > which is bad. > > if B's rwnd is not 0, it should send abord after Max.Retrans times, only when > B's rwnd == 0 and A's retransmitting beyonds Max.Retrans times, A will start > t5 timer, which is also commit f8d960524 means, but it lacks the condition > peer.rwnd == 0. > > Fixes: f8d960524 ("sctp: Enforce retransmission limit during shutdown") > Signed-off-by: Xin Long You still have typos on changelog, but at least not on keywords. Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/sm_statefuns.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c > index 3ee27b7..deb9eab 100644 > --- a/net/sctp/sm_statefuns.c > +++ b/net/sctp/sm_statefuns.c > @@ -5412,7 +5412,8 @@ sctp_disposition_t sctp_sf_do_6_3_3_rtx(struct net *net, > SCTP_INC_STATS(net, SCTP_MIB_T3_RTX_EXPIREDS); > > if (asoc->overall_error_count >= asoc->max_retrans) { > - if (asoc->state == SCTP_STATE_SHUTDOWN_PENDING) { > + if (!q->asoc->peer.rwnd && > + asoc->state == SCTP_STATE_SHUTDOWN_PENDING) { > /* > * We are here likely because the receiver had its rwnd > * closed for a while and we have not been able to > -- > 2.1.0 >