From: Florian Westphal <fw@strlen.de>
To: Akshat Kakkar <akshat.1984@gmail.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com
Subject: Re: iproute2: Behavioural Bug?
Date: Tue, 25 Aug 2015 01:22:29 +0200 [thread overview]
Message-ID: <20150824232229.GC5905@breakpoint.cc> (raw)
In-Reply-To: <CAA5aLPjmomaEv28==0wxtwNeRUguXimJqyWCEFNt0jrOkZ9O7g@mail.gmail.com>
Akshat Kakkar <akshat.1984@gmail.com> wrote:
[ CC Cong ]
> When I am trying to delete a single tc filter (i.e. specifying its
> handle), it is deleting all the
> filters with the same priority/preference. i.e. it is ignoring the
> handle specified.
>
> But, When I am doing similar activity in hashtable 800: it is deleting only the
> specified filter, i.e. it is behaving as expected.
>
> I am unable to comprehend the reason for this difference in behaviour.
>
> Infact, in kernel 2.6.32 all is working as expected. However, in
> kernel 3.1 and 4.1 it is having the behaviour as mentioned above.
>
> For example, following set of commands create a hashtable 15: and add
> 2 filters to it.
>
> tc filter add dev eth0 parent 1:0 prio 5 handle 15: protocol ip u32 divisor 256
> tc filter add dev eth0 protocol ip parent 1: prio 5 handle 15:2:2 u32
> ht 15:2: match ip src 10.0.0.2 flowid 1:10
> tc filter add dev eth0 protocol ip parent 1: prio 5 handle 15:2:3 u32
> ht 15:2: match ip src 10.0.0.3 flowid 1:10
>
> Now following command DELETES ALL THE FILTERS, though it should only
> delete FILTER 15:2:3 !
> tc filter del dev eth0 protocol ip parent 1: prio 5 handle 15:2:3 u32
>
> O/p of tc filter show eth0 is this case is blank. As all filters are deleted.
Happens since
1e052be69d045c8d0f82ff1116fd3e5a79661745
("net_sched: destroy proto tp when all filters are gone").
next prev parent reply other threads:[~2015-08-24 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 8:30 iproute2: Behavioural Bug? Akshat Kakkar
2015-08-24 19:17 ` Vadim Kochan
2015-08-24 23:22 ` Florian Westphal [this message]
2015-08-25 5:14 ` Akshat Kakkar
2015-08-25 6:08 ` Cong Wang
2015-08-25 7:18 ` Akshat Kakkar
2015-08-25 21:00 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824232229.GC5905@breakpoint.cc \
--to=fw@strlen.de \
--cc=akshat.1984@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).