From: David Miller <davem@davemloft.net>
To: achiad@mellanox.com
Cc: netdev@vger.kernel.org, amirv@mellanox.com,
ogerlitz@mellanox.com, saeedm@mellanox.com, talal@mellanox.com,
ranas@mellanox.com
Subject: Re: [PATCH net-next] net/mlx5e: Avoid accessing NULL pointer at ndo_select_queue
Date: Tue, 25 Aug 2015 13:45:24 -0700 (PDT) [thread overview]
Message-ID: <20150825.134524.1830707997009616231.davem@davemloft.net> (raw)
In-Reply-To: <1440335534-31279-1-git-send-email-achiad@mellanox.com>
From: Achiad Shochat <achiad@mellanox.com>
Date: Sun, 23 Aug 2015 16:12:14 +0300
> From: Rana Shahout <ranas@mellanox.com>
>
> To avoid multiply/division operations on the data path,
> we hold a {channel, tc}==>txq mapping table.
> We held this mapping table inside the channel object that is
> being destroyed upon some configuration operations (e.g MTU change).
> So in case ndo_select_queue occurs during such a configuration operation,
> it may access a NULL channel pointer, resulting in kernel panic.
> To fix this issue we moved the {channel, tc}==>txq mapping table
> outside the channel object so that it will be available also
> during such configuration operations.
>
>
> Signed-off-by: Rana Shahout <ranas@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2015-08-25 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 13:12 [PATCH net-next] net/mlx5e: Avoid accessing NULL pointer at ndo_select_queue Achiad Shochat
2015-08-25 20:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825.134524.1830707997009616231.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ranas@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).