From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: vinschen@redhat.com, netdev@vger.kernel.org,
hayeswang@realtek.com, ivecera@redhat.com, nic_swsd@realtek.com
Subject: Re: [PATCH v4 net-next] r8169: Add values missing in @get_stats64 from HW counters
Date: Tue, 25 Aug 2015 16:03:02 -0700 (PDT) [thread overview]
Message-ID: <20150825.160302.947112090610933000.davem@davemloft.net> (raw)
In-Reply-To: <20150825.155921.399025256241133988.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 25 Aug 2015 15:59:21 -0700 (PDT)
> From: Francois Romieu <romieu@fr.zoreil.com>
> Date: Wed, 26 Aug 2015 00:54:06 +0200
>
>>> Bringing the interface is brought down/up should not reset the
>>> counters.
>>
>> Afaiks rtl8169_tc_offsets.inited in rtl8169_init_counter_offsets
>> takes care of it: it's set during the first open() after probe().
>
> Ok, then it's fine.
And as such I've applied this patch, thanks.
next prev parent reply other threads:[~2015-08-25 23:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:04 [PATCH] r8169: Add values missing in @get_stats64 from HW counters Corinna Vinschen
2015-08-18 21:40 ` Francois Romieu
2015-08-19 2:05 ` David Miller
2015-08-19 9:10 ` Corinna Vinschen
2015-08-19 2:51 ` Hayes Wang
2015-08-19 9:13 ` Corinna Vinschen
2015-08-19 9:31 ` Hayes Wang
2015-08-19 13:07 ` Corinna Vinschen
2015-08-19 14:24 ` Corinna Vinschen
2015-08-19 19:24 ` Corinna Vinschen
2015-08-20 2:43 ` Hayes Wang
2015-08-20 9:41 ` Corinna Vinschen
2015-08-20 9:56 ` Hayes Wang
2015-08-21 10:09 ` [PATCH v2 net-next] " Corinna Vinschen
2015-08-21 10:24 ` Corinna Vinschen
2015-08-21 19:39 ` Francois Romieu
2015-08-21 22:07 ` Corinna Vinschen
2015-08-21 23:59 ` Francois Romieu
2015-08-22 8:39 ` Corinna Vinschen
2015-08-22 11:23 ` Francois Romieu
2015-08-24 7:33 ` Corinna Vinschen
2015-08-24 10:29 ` Corinna Vinschen
2015-08-24 23:33 ` Francois Romieu
2015-08-25 8:39 ` Corinna Vinschen
2015-08-25 21:14 ` Francois Romieu
2015-08-24 10:27 ` [PATCH v3 " Corinna Vinschen
2015-08-24 10:52 ` [PATCH v4 " Corinna Vinschen
2015-08-25 21:15 ` David Miller
2015-08-25 22:54 ` Francois Romieu
2015-08-25 22:59 ` David Miller
2015-08-25 23:03 ` David Miller [this message]
2015-08-26 8:55 ` Corinna Vinschen
2015-08-26 8:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825.160302.947112090610933000.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).