From: Thomas Graf <tgraf@suug.ch>
To: Jesse Gross <jesse@nicira.com>
Cc: Pravin Shelar <pshelar@nicira.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.
Date: Tue, 25 Aug 2015 19:48:01 +0200 [thread overview]
Message-ID: <20150825174801.GD3707@pox.localdomain> (raw)
In-Reply-To: <CAEP_g=9Fpb9KOeqeeK_dbCdec8TvHm-iUZ4V_MWj1Mc21Qa9OQ@mail.gmail.com>
On 08/25/15 at 09:50am, Jesse Gross wrote:
> On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar <pshelar@nicira.com> wrote:
> > Moving this device means moving all tunnels backed by this device
> > rather than specific tunnel device. Thats why it does not look right
> > to move such device.
>
> I agree it seems weird in general. There were two things that made me wonder:
> * It doesn't appear that VXLAN or GRE do this.
> * The use case for moving a single tunnel to a different namespace is
> to have the device and socket live in different places. I guess
> conceptually this could apply to collect_md devices as well. (Maybe to
> have harder isolation between inside and outside the tunnel?)
>
> I'm not really sure what the best answer is but at least we should be
> consistent across tunnel types.
I agree with Jesse that consistent behaviour is desirable. If needed,
let's change it for all encap types.
next prev parent reply other threads:[~2015-08-25 17:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 17:43 [PATCH v3 net-next 0/8] Geneve: Add support for tunnel metadata mode Pravin B Shelar
2015-08-24 17:43 ` [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup Pravin B Shelar
2015-08-26 20:42 ` John W. Linville
2015-08-24 17:43 ` [PATCH v3 net-next 2/8] geneve: Use skb mark and protocol to lookup route Pravin B Shelar
2015-08-26 20:46 ` John W. Linville
2015-08-24 17:43 ` [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst() Pravin B Shelar
2015-08-24 22:02 ` Jesse Gross
2015-08-25 17:46 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 4/8] geneve: Make dst-port configurable Pravin B Shelar
2015-08-25 17:47 ` Thomas Graf
2015-08-26 20:47 ` John W. Linville
2015-08-24 17:43 ` [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata Pravin B Shelar
2015-08-25 1:42 ` Jesse Gross
2015-08-25 2:15 ` Pravin Shelar
2015-08-25 16:50 ` Jesse Gross
2015-08-25 17:48 ` Thomas Graf [this message]
2015-08-25 21:16 ` Pravin Shelar
2015-08-25 18:12 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 6/8] openvswitch: Use Geneve device Pravin B Shelar
2015-08-25 17:48 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module Pravin B Shelar
2015-08-25 18:19 ` Thomas Graf
2015-08-25 20:55 ` Pravin Shelar
2015-08-25 19:03 ` Jesse Gross
2015-08-25 20:54 ` Pravin Shelar
2015-08-25 21:35 ` Jesse Gross
2015-08-26 0:05 ` Pravin Shelar
2015-08-24 17:43 ` [PATCH v3 net-next 8/8] geneve: Move device hash table to geneve socket Pravin B Shelar
2015-08-26 21:14 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825174801.GD3707@pox.localdomain \
--to=tgraf@suug.ch \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).