Netdev List
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: vyasevic@redhat.com, bridge@lists.linux-foundation.org,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	netdev@vger.kernel.org, wkok@cumulusnetworks.com,
	davem@davemloft.net
Subject: Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans
Date: Tue, 25 Aug 2015 17:58:20 -0700	[thread overview]
Message-ID: <20150825175820.0b0538c1@urahara> (raw)
In-Reply-To: <1440549295-3979-1-git-send-email-razor@blackwall.org>

On Tue, 25 Aug 2015 17:34:55 -0700
Nikolay Aleksandrov <razor@blackwall.org> wrote:

> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 3d95647039d0..2bda472c5a6e 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -294,6 +294,7 @@ struct net_bridge
>  	u32				auto_cnt;
>  #ifdef CONFIG_BRIDGE_VLAN_FILTERING
>  	u8				vlan_enabled;
> +	bool				vlan_ignore_local_fdb;

bool takes more space than u8.


>  	__be16				vlan_proto;
>  	u16				default_pvid;
>  	struct net_port_vlans __rcu	*vlan_info;

> +int br_vlan_ignore_local_fdb_toggle(struct net_bridge *br, unsigned long val)
> +{
> +	br->vlan_ignore_local_fdb = val ? true : false;

personal preference is for:
	br->vlan_ignore_local_fdb = !!val;

  parent reply	other threads:[~2015-08-26  0:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26  0:34 [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans Nikolay Aleksandrov
2015-08-26  0:56 ` Stephen Hemminger
2015-08-26  5:42   ` Nikolay Aleksandrov
2015-08-26  0:58 ` Stephen Hemminger [this message]
2015-08-26  2:42 ` David Miller
2015-08-26  5:28   ` Nikolay Aleksandrov
2015-08-26  6:06     ` David Miller
2015-08-26 11:33       ` Nikolay Aleksandrov
2015-08-27  4:57         ` roopa
2015-08-27 21:02           ` Nikolay Aleksandrov
2015-08-27 23:47             ` Vlad Yasevich
2015-08-28  2:17               ` Nikolay Aleksandrov
2015-08-28 12:31                 ` Vlad Yasevich
2015-08-28 15:26                   ` Nikolay Aleksandrov
2015-08-29  1:11                     ` Vlad Yasevich
2015-09-13 13:22                       ` Nikolay Aleksandrov
2015-08-26  6:10     ` B Viswanath
2015-08-26 12:52       ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825175820.0b0538c1@urahara \
    --to=stephen@networkplumber.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=razor@blackwall.org \
    --cc=vyasevic@redhat.com \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox