From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: sfeldma@gmail.com, netdev@vger.kernel.org, idosch@mellanox.com,
eladr@mellanox.com, ogerlitz@mellanox.com, jiri@mellanox.com
Subject: Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs
Date: Wed, 26 Aug 2015 23:36:03 -0700 (PDT) [thread overview]
Message-ID: <20150826.233603.681080899557993733.davem@davemloft.net> (raw)
In-Reply-To: <20150827062704.GE2228@nanopsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 27 Aug 2015 08:27:04 +0200
> I'm not saying it is not possible, it certainly is. But I think that
> for example rocker internals have no value to default user, he
> should not care and he cannot find out what is going on there
> without knowledge or rocker.c code. The question is, do we need some
> standard interface to expose random debugging data? I don't think
> so, I think that debugfs is exactly the tool to be used in that
> case.
If it is only interesting to rocker.c maintainer, he can keep a local
patch he applies when he needs such a facility.
This discussion is becomming circular.
If it's useful, it needs a well defined interface.
If it's not useful, it doesn't belong in the tree.
Therefore, debugfs is useless.
next prev parent reply other threads:[~2015-08-27 6:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 14:45 [patch net-next 0/3] mlxsw: small driver update Jiri Pirko
2015-08-24 14:45 ` [patch net-next 1/3] mlxsw: Remove duplicate included header Jiri Pirko
2015-08-24 14:45 ` [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs Jiri Pirko
2015-08-25 21:25 ` David Miller
2015-08-26 5:52 ` Jiri Pirko
2015-08-26 6:08 ` David Miller
2015-08-26 7:37 ` Jiri Pirko
2015-08-26 17:49 ` David Miller
2015-08-26 18:21 ` Scott Feldman
2015-08-26 18:36 ` Florian Fainelli
2015-08-27 0:26 ` David Miller
2015-08-27 5:40 ` Jiri Pirko
2015-08-27 6:01 ` David Miller
2015-08-27 6:27 ` Jiri Pirko
2015-08-27 6:36 ` David Miller [this message]
2015-08-27 6:40 ` Jiri Pirko
2015-09-16 13:14 ` Marcelo Ricardo Leitner
2015-08-24 14:45 ` [patch net-next 3/3] mlxsw: adjust log messages level in __mlxsw_emad_transmit Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826.233603.681080899557993733.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).