From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, mleitner@redhat.com, vyasevic@redhat.com
Subject: Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning
Date: Thu, 27 Aug 2015 14:00:00 -0700 (PDT) [thread overview]
Message-ID: <20150827.140000.2029372676821851500.davem@davemloft.net> (raw)
In-Reply-To: <842bb5735d0ea0e632695f49dc85021faa176784.1440663994.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 27 Aug 2015 16:26:34 +0800
> in sctp_process_asconf(), we get address parameter from the beginning of
> the addip params. but we never check if it's really there. if the addr
> param is not there, it still can pass sctp_verify_asconf(), then to be
> handled by sctp_process_asconf(), it will not be safe.
>
> so add a code in sctp_verify_asconf() to check the address parameter is in
> the beginning, or return false to send abort.
>
> note that this can also detect multiple address parameters, and reject it.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2015-08-27 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 8:26 [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning Xin Long
2015-08-27 12:46 ` Vlad Yasevich
2015-08-27 21:00 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-26 21:03 Xin Long
2015-08-26 21:33 ` Vlad Yasevich
2015-08-27 8:25 ` lucien xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827.140000.2029372676821851500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).