netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>, "Ji??í Pírko" <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Roopa Prabhu" <roopa@cumulusnetworks.com>
Subject: Re: [RFC PATCH net-next 0/2] Add new switchdev device class
Date: Thu, 27 Aug 2015 11:06:03 +0200	[thread overview]
Message-ID: <20150827090603.GC8094@lunn.ch> (raw)
In-Reply-To: <CAE4R7bD0Ka0187Qq=+6cZL7UqgnxJASKL_6AmaC2z_jiF5Jp1w@mail.gmail.com>

On Thu, Aug 27, 2015 at 01:42:24AM -0700, Scott Feldman wrote:
> On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn <andrew@lunn.ch> wrote:
> >> I don't know about how this overlaps with DSA platform_class.  Florian?
> >
> > There is some overlap with DSA, but the current DSA model, with
> > respect to probing, is broken. So this might be interesting as a way
> > towards fix that.
> >
> > One thing to keep in mind is the D in DSA. You talk about switch,
> > singular. DSA has a number of switches in a cluster. We currently
> > export a single switchdev interface for the cluster, but there are
> > some properties which are per switch, e.g. temperature, eeprom
> > contents, statistics, power management etc.
> 
> Export a single 'switchdev' or 'netdev' for the cluster?  I hope that
> was a typo.

I probably expressed that badly. The hardware i have on my desk has
three Marvell switches in a chain, with one end of the chain connected
to a host Ethernet interface.

>From the switchdev ops level, you don't see anything of this
chain. But some of the operations do need to be aware of this chain,
for example vlans which span multiple chips in this chain.

> With switchdev device class, you'd instantiate one per
> phy switch, and have per-switch props (temp, eeprom, etc) thru each
> switchdev instance.

O.K. This is fine, but we need people to understand that a switchdev
device class represents some middle layer in the hierarchy, not the
top layer. Otherwise false assumptions might be made.

    Andrew

  reply	other threads:[~2015-08-27  9:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  7:16 [RFC PATCH net-next 0/2] Add new switchdev device class sfeldma
2015-08-27  7:16 ` [RFC PATCH net-next 1/2] switchdev: create " sfeldma
2015-08-27  7:16 ` [RFC PATCH net-next 2/2] rocker: register each switch as a switchdev sfeldma
2015-08-27  7:27 ` [RFC PATCH net-next 0/2] Add new switchdev device class Jiri Pirko
2015-08-27  7:43   ` John Fastabend
2015-08-27  7:51     ` Jiri Pirko
2015-08-27  8:14       ` John Fastabend
2015-08-27  8:17   ` Scott Feldman
2015-08-27  8:41     ` Jiri Pirko
2015-08-27  7:36 ` John Fastabend
2015-08-27  7:44   ` Jiri Pirko
2015-08-27  8:09     ` John Fastabend
2015-08-27  8:23   ` Scott Feldman
2015-08-27  7:45 ` Andrew Lunn
2015-08-27  8:42   ` Scott Feldman
2015-08-27  9:06     ` Andrew Lunn [this message]
2015-08-27 16:41       ` Scott Feldman
2015-08-28 11:52         ` Andrew Lunn
2015-08-27 13:54 ` John W. Linville
2015-08-27 23:25 ` David Miller
2015-08-28  2:13 ` Arad, Ronen
2015-08-28 16:55   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827090603.GC8094@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).