From: David Miller <davem@davemloft.net>
To: razor@blackwall.org
Cc: netdev@vger.kernel.org, 13806511171@163.com,
shemminger@linux-foundation.org, maheshb@google.com,
j.vosburgh@gmail.com, vfalico@gmail.com,
gospo@cumulusnetworks.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net v3] bonding: fix bond_poll_controller bh_enable warning
Date: Fri, 28 Aug 2015 22:26:45 -0700 (PDT) [thread overview]
Message-ID: <20150828.222645.1574109168572497876.davem@davemloft.net> (raw)
In-Reply-To: <1440799532-9150-1-git-send-email-razor@blackwall.org>
From: Nikolay Aleksandrov <razor@blackwall.org>
Date: Fri, 28 Aug 2015 15:05:32 -0700
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> The problem is rcu_read_unlock_bh() which triggers a warning when irqs are
> disabled. ndo_poll_controller should run with irqs disabled always so we
> can drop the rcu_read_lock_bh.
...
> Fixes: 616f45416ca0 ("bonding: implement bond_poll_controller()")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> v3: After Dave made it clear that poll_controller should always be called
> with interrupts disabled we can simply drop the rcu bh lock.
Applied.
prev parent reply other threads:[~2015-08-29 5:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 0:15 Fw: [Bug 102181] New: kernel soft lockup when using tcp_keepalive_timer Stephen Hemminger
2015-08-28 1:54 ` [PATCH net] bonding: fix bond_poll_controller bh_enable warning Nikolay Aleksandrov
2015-08-28 15:33 ` Nikolay Aleksandrov
2015-08-28 17:22 ` [PATCH net v2] " Nikolay Aleksandrov
2015-08-28 21:13 ` David Miller
2015-08-28 21:59 ` Nikolay Aleksandrov
2015-08-28 22:05 ` [PATCH net v3] " Nikolay Aleksandrov
2015-08-28 22:32 ` Mahesh Bandewar
2015-08-29 5:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828.222645.1574109168572497876.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=13806511171@163.com \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=shemminger@linux-foundation.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox