From: Thomas Graf <tgraf@suug.ch>
To: Pravin Shelar <pshelar@nicira.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.
Date: Fri, 28 Aug 2015 12:22:13 +0200 [thread overview]
Message-ID: <20150828102213.GG32206@pox.localdomain> (raw)
In-Reply-To: <CALnjE+pDWPEbuZ1--bk433x39BXvkf6ZcMcfhbg45DZBMV+HBQ@mail.gmail.com>
On 08/27/15 at 02:29pm, Pravin Shelar wrote:
> On Thu, Aug 27, 2015 at 2:18 AM, Thomas Graf <tgraf@suug.ch> wrote:
> > It is slightly non obvious that introducing an error condition above
> > this and before udp_tun_rx_dst() would introduce a memory leak. Other
> > than this looks great now.
> >
> I can not move this into if condition block since skb-scrub-packet
> drops skb dst entry.
I understand, VXLAN does the same. A comment would help though.
next prev parent reply other threads:[~2015-08-28 10:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 6:46 [PATCH v5 net-next 0/8] geneve: Add support for tunnel metadata mode Pravin B Shelar
2015-08-27 6:46 ` [PATCH v5 net-next 1/8] geneve: Initialize ethernet address in device setup Pravin B Shelar
2015-08-27 6:46 ` [PATCH v5 net-next 2/8] geneve: Use skb mark and protocol to lookup route Pravin B Shelar
2015-08-27 6:46 ` [PATCH v5 net-next 3/8] tunnel: introduce udp_tun_rx_dst() Pravin B Shelar
2015-08-27 6:46 ` [PATCH v5 net-next 4/8] geneve: Make dst-port configurable Pravin B Shelar
2015-08-27 6:46 ` [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata Pravin B Shelar
2015-08-27 9:18 ` Thomas Graf
2015-08-27 21:29 ` Pravin Shelar
2015-08-28 10:22 ` Thomas Graf [this message]
2015-08-27 6:46 ` [PATCH v5 net-next 6/8] openvswitch: Use Geneve device Pravin B Shelar
2015-08-27 9:19 ` Thomas Graf
2015-08-27 6:46 ` [PATCH v5 net-next 7/8] geneve: Consolidate Geneve functionality in single module Pravin B Shelar
2015-08-27 16:31 ` Jesse Gross
2015-08-27 17:28 ` John W. Linville
2015-08-27 6:46 ` [PATCH v5 net-next 8/8] geneve: Move device hash table to geneve socket Pravin B Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828102213.GG32206@pox.localdomain \
--to=tgraf@suug.ch \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox