From: Thomas Graf <tgraf@suug.ch>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Pravin Shelar <pshelar@nicira.com>
Subject: Re: [PATCH v2 net-next 2/4] ip_tunnels: record IP version in tunnel info
Date: Sat, 29 Aug 2015 00:24:11 +0200 [thread overview]
Message-ID: <20150828222411.GB32001@pox.localdomain> (raw)
In-Reply-To: <5f1807433565275c8bf699c0495b66c620b274c7.1440787600.git.jbenc@redhat.com>
On 08/28/15 at 08:48pm, Jiri Benc wrote:
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index e2dc9dac59e6..40164037928e 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -587,6 +587,8 @@ int ovs_tunnel_get_egress_info(struct ip_tunnel_info *egress_tun_info,
>
> if (unlikely(!tun_info))
> return -EINVAL;
> + if (ip_tunnel_info_af(tun_info) != AF_INET)
> + return -EINVAL;
>
> tun_key = &tun_info->key;
Are you sure this chunk is needed? It looks like OVS_CB()->egress_tun_info
can only be set via execute_set_action() which can only be of a supported
AF type.
Otherwise this looks great.
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-08-28 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 18:48 [PATCH v2 net-next 0/4] tunnels: fix incorrect IPv4/v6 headers interpretation Jiri Benc
2015-08-28 18:48 ` [PATCH v2 net-next 1/4] ip_tunnels: convert the mode field of ip_tunnel_info to flags Jiri Benc
2015-08-28 22:15 ` Thomas Graf
2015-08-28 22:55 ` Pravin Shelar
2015-08-28 18:48 ` [PATCH v2 net-next 2/4] ip_tunnels: record IP version in tunnel info Jiri Benc
2015-08-28 22:24 ` Thomas Graf [this message]
2015-08-29 8:43 ` Jiri Benc
2015-08-28 22:55 ` Pravin Shelar
2015-08-28 18:48 ` [PATCH v2 net-next 3/4] fou: reject IPv6 config Jiri Benc
2015-08-28 18:48 ` [PATCH v2 net-next 4/4] vxlan: do not receive IPv4 packets on IPv6 socket Jiri Benc
2015-08-28 22:39 ` Thomas Graf
2015-08-29 8:55 ` Jiri Benc
2015-08-30 9:30 ` Thomas Graf
2015-08-29 20:08 ` [PATCH v2 net-next 0/4] tunnels: fix incorrect IPv4/v6 headers interpretation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828222411.GB32001@pox.localdomain \
--to=tgraf@suug.ch \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox