From: Francois Romieu <romieu@fr.zoreil.com>
To: Corcodel Marian <corcodel.marian@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH, net-next] r8169: Deny functions membet of array rtl_work
Date: Sat, 29 Aug 2015 13:26:30 +0200 [thread overview]
Message-ID: <20150829112630.GA8873@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1440845029-3079-1-git-send-email-corcodel.marian@gmail.com>
Corcodel Marian <corcodel.marian@gmail.com> :
> Deny functions member of array rtl_work to run when link is
> ok.After rtl8169_init_phy exist 10 sec timeout.On many cases link is ok and
> no need to destroy all work.
I won't figure what happens outside of the "many cases" statement.
rtl_reset_work is a hard reset. It isn't supposed to go shopping just
because the link seems to be established. Moreover you don't explain why
you need to vandalize rtl_phy_work (unrelated to any 10 sec timeout).
As usual nobody knows how it was tested (suspend/resume, change location
and port, etc.).
Please don't send me private only e-mail.
--
Ueimor
next prev parent reply other threads:[~2015-08-29 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 10:43 [PATCH, net-next] r8169: Deny functions membet of array rtl_work Corcodel Marian
2015-08-29 11:26 ` Francois Romieu [this message]
[not found] ` <CAGg4U=HQwGhQ95+FNumjLOH0m5Bnm8-3kOgfbMUGOV=Lzsyd6A@mail.gmail.com>
2015-08-30 8:13 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829112630.GA8873@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=corcodel.marian@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox