From: Stephen Hemminger <stephen@networkplumber.org>
To: Mike Saal <msaal@qacafe.com>
Cc: netdev@vger.kernel.org
Subject: Re: ss format bug
Date: Mon, 31 Aug 2015 16:23:16 -0700 [thread overview]
Message-ID: <20150831162316.5e1a9b9e@urahara> (raw)
In-Reply-To: <55DDE255.1010003@qacafe.com>
On Wed, 26 Aug 2015 11:59:17 -0400
Mike Saal <msaal@qacafe.com> wrote:
> Hi:
>
> I found a formatting bug in the 4.1.1 ss command. The following line was
> incorrectly output due to passing a negative length to printf() when
> displaying the local address. In this instance hostapd does a "bind to
> device" on cdreth0 and then does a udp "in address any" port 67 bind.
> Please note the whitespace between the '*' and ' %cdreth0:67'
>
> 'udp UNCONN 0 0 ** %cdreth0:67* *:* users:(("hostapd",pid=19241,fd=5))'
>
> Attached is my patch for the bug fix, it might be prudent to add more
> guard code looking for negative length format codes.
>
> Sincerely, Mike
I think the root cause of this is actually down in the main program
where it is computing addr_width. It is not accounting for the size correctly,
or maybe your case just occurs if screen is too narrow to fit the full width.
prev parent reply other threads:[~2015-08-31 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 15:59 ss format bug Mike Saal
2015-08-31 23:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831162316.5e1a9b9e@urahara \
--to=stephen@networkplumber.org \
--cc=msaal@qacafe.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox