From: David Miller <davem@davemloft.net>
To: Yanjun.Zhu@windriver.com
Cc: netdev@vger.kernel.org, therbert@google.com, jhs@mojatatu.com,
hannes@stressinduktion.org, edumazet@google.com,
jeffrey.t.kirsher@intel.com, rusty@rustcorp.com.au,
dborkman@redhat.com, brouer@redhat.com
Subject: Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.
Date: Tue, 01 Sep 2015 00:00:51 -0700 (PDT) [thread overview]
Message-ID: <20150901.000051.2053259950492309439.davem@davemloft.net> (raw)
In-Reply-To: <55E549CE.4010509@windriver.com>
From: yzhu1 <Yanjun.Zhu@windriver.com>
Date: Tue, 1 Sep 2015 14:46:38 +0800
> After I applied this patch, the skb->xmit_more is not always zero.
There have been thousands upon thousands of commits since that
change.
You should be testing the tree as it currently stands, to see
if xmit_more behaves correctly or not.
If xmit_more were incorrectly set to 1 in the current tree, it
would stall the TX queue of the networking device and we would
be seeing lots of reports of this.
next prev parent reply other threads:[~2015-09-01 7:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 23:35 [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead David Miller
2014-08-26 3:42 ` Tom Herbert
2014-08-26 4:50 ` David Miller
2015-09-01 6:46 ` yzhu1
2015-09-01 7:00 ` David Miller [this message]
2015-09-01 7:10 ` yzhu1
2015-09-01 7:13 ` David Miller
2015-09-01 8:23 ` Daniel Borkmann
2015-09-01 9:21 ` yzhu1
2015-09-01 16:22 ` Alexander Duyck
2015-09-01 16:49 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901.000051.2053259950492309439.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yanjun.Zhu@windriver.com \
--cc=brouer@redhat.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).