From: David Miller <davem@davemloft.net>
To: msalter@redhat.com
Cc: ddaney.cavm@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
buytenh@wantstofly.org, grant.likely@secretlab.ca
Subject: Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister()
Date: Tue, 01 Sep 2015 15:03:04 -0700 (PDT) [thread overview]
Message-ID: <20150901.150304.562643685874217745.davem@davemloft.net> (raw)
In-Reply-To: <1441114565-2340-1-git-send-email-msalter@redhat.com>
From: Mark Salter <msalter@redhat.com>
Date: Tue, 1 Sep 2015 09:36:05 -0400
> commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> the bus' parent.") uncovered a problem in mdiobus_unregister() which
> leads to this warning when I reboot an APM Mustang (arm64) platform:
...
> The problem is that mdiobus_unregister() deletes the bus device before
> unregistering the phy devices on the bus. This wasn't a problem before
> because the phys were not children of the bus:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0
>
> But now that they are:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03
>
> when mdiobus_unregister deletes the bus device, the phy subdirs are
> removed from sysfs also. So when the phys are unregistered afterward,
> we get the warning. This patch changes the order so that phys are
> unregistered before the bus device is deleted.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-09-01 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 13:36 [PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Salter
2015-09-01 13:55 ` Florian Fainelli
2015-09-01 14:07 ` Mark Langsdorf
2015-09-01 22:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901.150304.562643685874217745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=ddaney.cavm@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).