From: Phil Sutter <phil@nwl.cc>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: tgraf@suug.ch, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
wfg@linux.intel.com, lkp@01.org
Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads
Date: Tue, 1 Sep 2015 15:56:18 +0200 [thread overview]
Message-ID: <20150901135618.GD27550@orbit.nwl.cc> (raw)
In-Reply-To: <20150901135019.GA13629@gondor.apana.org.au>
On Tue, Sep 01, 2015 at 09:50:19PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 03:43:11PM +0200, Phil Sutter wrote:
> >
> > Hmm. Since memory allocation is first tried with GFP_ATOMIC set and upon
> > failure retried in background, this seems like a situation which might
> > happen during normal use. If that already indicates a severe problem,
> > why retry in background at all?
>
> It should be tried in the background first at 70% and only when
> that fails would we hit the 100% case and then we will try it
> with GFP_ATOMIC. If that fails then the insertion will fail.
Ah, good to know. Thanks for clarifying this!
Looking at rhashtable_test.c, I see the initial table size is 8 entries.
70% of that is 5.6 entries, so background expansion is started after the
6th entry has been added, right? Given there are 10 threads running
which try to insert 50k entries at the same time, I don't think it's
unlikely that three more entries are inserted before the background
expansion completes.
Cheers, Phil
next prev parent reply other threads:[~2015-09-01 13:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 10:28 [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Phil Sutter
2015-08-28 10:28 ` [PATCH 2/3] rhashtable-test: retry insert operations in threads Phil Sutter
2015-08-28 11:09 ` Thomas Graf
2015-08-28 11:13 ` Phil Sutter
2015-08-28 13:34 ` Phil Sutter
2015-08-28 22:43 ` Thomas Graf
2015-08-29 9:07 ` Phil Sutter
2015-08-30 7:47 ` Herbert Xu
2015-08-31 11:00 ` Phil Sutter
2015-09-01 11:43 ` Herbert Xu
2015-09-01 12:46 ` Phil Sutter
2015-09-01 13:00 ` Herbert Xu
2015-09-01 13:40 ` Eric Dumazet
2015-09-01 13:43 ` Phil Sutter
2015-09-01 13:50 ` Herbert Xu
2015-09-01 13:56 ` Phil Sutter [this message]
2015-09-01 14:03 ` Herbert Xu
2015-09-01 14:13 ` Thomas Graf
2015-09-01 14:16 ` Herbert Xu
2015-09-01 14:51 ` Thomas Graf
2015-09-02 2:00 ` Herbert Xu
2015-09-02 7:07 ` Thomas Graf
2015-09-10 8:03 ` Herbert Xu
2015-09-10 10:05 ` Phil Sutter
2015-08-28 10:28 ` [PATCH 3/3] rhashtable-test: calculate max_entries value by default Phil Sutter
2015-08-28 11:11 ` Thomas Graf
2015-08-28 11:03 ` [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901135618.GD27550@orbit.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).