From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Philippe De Muyter <phdm@macq.eu>
Cc: Fugang Duan <b38611@freescale.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/1] net: fec: clear receive interrupts before processing a packet
Date: Wed, 2 Sep 2015 10:46:58 +0100 [thread overview]
Message-ID: <20150902094658.GO21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150902094015.GA27372@frolo.macqel>
On Wed, Sep 02, 2015 at 11:40:15AM +0200, Philippe De Muyter wrote:
> On Wed, Sep 02, 2015 at 05:24:14PM +0800, Fugang Duan wrote:
> > From: Russell King <rmk+kernel@arm.linux.org.uk>
> >
> > The patch just to re-submit the patch "db3421c114cfa6326" because the
> > patch "4d494cdc92b3b9a0" remove the change.
>
> I think you should mention also the titles of the commits.
Yes, that's standard kernel procedure. Also, 12 characters of commit ID
is the recommended length.
> Could a comment be added here to avoid another future removal ?
I think reading the commit messages introducing the code would also help,
but a comment wouldn't hurt.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-09-02 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 9:24 [PATCH net-next 1/1] net: fec: clear receive interrupts before processing a packet Fugang Duan
2015-09-02 9:40 ` Philippe De Muyter
2015-09-02 9:46 ` Russell King - ARM Linux [this message]
2015-09-03 8:00 ` Philippe De Muyter
2015-09-03 14:40 ` Duan Andy
2015-09-02 23:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902094658.GO21084@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=b38611@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=phdm@macq.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).