netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Support ip route get via given table
Date: Wed, 2 Sep 2015 21:12:44 +0200	[thread overview]
Message-ID: <20150902191244.GE20527@pox.localdomain> (raw)
In-Reply-To: <1441220592-7339-1-git-send-email-dsa@cumulusnetworks.com>

On 09/02/15 at 12:03pm, David Ahern wrote:
> Add support for 'ip [-6] route get table X' where the user wants to
> force the FIB lookup from a given table.
> 
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>

Will you use this outside of 'ip route get' as well? If so, how? I'm
asking because you propose to add the check and new behaviour to bypass
the routing rules to the routing fastpath, wouldn't it be better to
handle this in inet_rtm_getroute()?

  reply	other threads:[~2015-09-02 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 19:03 [PATCH net-next] net: Support ip route get via given table David Ahern
2015-09-02 19:12 ` Thomas Graf [this message]
2015-09-02 19:22   ` David Ahern
2015-09-02 19:38     ` Thomas Graf
2015-09-02 19:50       ` David Ahern
2015-09-03 22:40 ` David Miller
2015-09-03 23:25   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150902191244.GE20527@pox.localdomain \
    --to=tgraf@suug.ch \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).