From: Thomas Graf <tgraf@suug.ch>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: Add table id from route lookup to route response
Date: Wed, 2 Sep 2015 22:23:14 +0200 [thread overview]
Message-ID: <20150902202314.GC25648@pox.localdomain> (raw)
In-Reply-To: <1441224980-6201-1-git-send-email-dsa@cumulusnetworks.com>
On 09/02/15 at 01:16pm, David Ahern wrote:
> IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
> hit for the route lookup. Add the table using a new attribute,
> RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
>
> Thomas: Something like this?
>
> The current ABI is returning wrong data in some cases; that seems worse
> to me than breaking the ABI.
Another option is to introduce a new flag bundled with RTM_GETROUTE
which fixes RTM_GETROUTE altogether and makes it return the actual
route instead of a simulated cache entry.
next prev parent reply other threads:[~2015-09-02 20:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 16:40 [PATCH net-next 1/3] net: Refactor rtable initialization David Ahern
2015-09-02 16:40 ` [PATCH net-next 2/3] net: Add FIB table id to rtable David Ahern
2015-09-02 16:40 ` [PATCH net-next 3/3] net: Add table id from route lookup to route response David Ahern
2015-09-02 18:43 ` Thomas Graf
2015-09-02 18:49 ` David Miller
2015-09-02 18:51 ` David Ahern
2015-09-02 19:08 ` Thomas Graf
2015-09-02 19:43 ` Andy Gospodarek
2015-09-02 20:18 ` Thomas Graf
2015-09-02 22:33 ` David Miller
2015-09-02 20:16 ` [PATCH net-next v2] " David Ahern
2015-09-02 20:23 ` Thomas Graf [this message]
2015-09-02 20:34 ` David Ahern
2015-09-02 20:41 ` Alexander Duyck
2015-09-02 20:47 ` David Ahern
2015-09-02 20:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902202314.GC25648@pox.localdomain \
--to=tgraf@suug.ch \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).