From: David Miller <davem@davemloft.net>
To: nforro@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: Fix behaviour of unreachable, blackhole and prohibit routes
Date: Thu, 03 Sep 2015 10:29:55 -0700 (PDT) [thread overview]
Message-ID: <20150903.102955.927476775467830647.davem@davemloft.net> (raw)
In-Reply-To: <1441271331.3360.36.camel@redhat.com>
From: Nikola Forró <nforro@redhat.com>
Date: Thu, 03 Sep 2015 11:08:51 +0200
> @@ -233,8 +233,10 @@ static inline int fib_lookup(struct net *net, const struct flowi4 *flp,
> rcu_read_lock();
>
> tb = fib_get_table(net, RT_TABLE_MAIN);
> - if (tb && !fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF))
> - err = 0;
> + if (tb)
> + err = fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF);
> + if (err == -EAGAIN)
> + err = -ENETUNREACH;
You didn't test this.
next prev parent reply other threads:[~2015-09-03 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:08 [PATCH v2] net: Fix behaviour of unreachable, blackhole and prohibit routes Nikola Forró
2015-09-03 9:13 ` Florian Westphal
2015-09-03 10:01 ` Nikola Forró
2015-09-03 17:29 ` David Miller [this message]
2015-09-03 22:22 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903.102955.927476775467830647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nforro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).