From: Phil Sutter <phil@nwl.cc>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [net-next PATCH] net: kill default_pref field of struct fib_rules_ops
Date: Sun, 6 Sep 2015 11:54:30 +0200 [thread overview]
Message-ID: <20150906095349.0AC0E20900@mail.nwl.cc> (raw)
In-Reply-To: <20150905.220040.768580139044156666.davem@davemloft.net>
On Sat, Sep 05, 2015 at 10:00:40PM -0700, David Miller wrote:
> From: Phil Sutter <phil@nwl.cc>
> Date: Thu, 3 Sep 2015 13:10:22 +0200
>
> > Since now all users of that field have been converted to use the generic
> > function fib_default_rule_pref() when assigning to it, fib_nl_newrule()
> > may just use it directly instead.
> >
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
>
> I did not instruct you to submit this change assuming I had applied
> your ipv6 one. Which I did not and will not do.
>
> Instead, I want you to do it all in one go.
Ah. No biggie, I'll fold them together then. Just found it useful to
separate the logically unrelated changes in different commits.
Cheers, Phil
next prev parent reply other threads:[~2015-09-06 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 13:03 [net-next PATCH] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-02 18:34 ` David Miller
2015-09-02 18:46 ` Thomas Graf
2015-09-03 11:10 ` [net-next PATCH] net: kill default_pref field of struct fib_rules_ops Phil Sutter
2015-09-06 5:00 ` David Miller
2015-09-06 9:54 ` Phil Sutter [this message]
2015-09-06 10:20 ` [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-09 5:37 ` David Miller
2015-09-09 5:38 ` David Miller
2015-09-09 11:45 ` Phil Sutter
2015-09-09 12:20 ` [net-next PATCH v3] " Phil Sutter
2015-09-09 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906095349.0AC0E20900@mail.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).