From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, pomidorabelisima@gmail.com
Subject: Re: [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.
Date: Mon, 07 Sep 2015 00:05:30 -0700 (PDT) [thread overview]
Message-ID: <20150907.000530.2280325695730676502.davem@davemloft.net> (raw)
In-Reply-To: <20150906202153.GB19371@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sun, 6 Sep 2015 22:21:53 +0200
> Corinna Vinschen <vinschen@redhat.com> :
>> On Sep 5 14:18, romieu@fr.zoreil.com wrote:
> [...]
>> > - rtl_reset_counters_cond induced failures in open() are also considered
>> > fatal: it takes acceptable work to unwind comfortably.
>>
>> Why?
>
>
> Crap, my description does not match the code wrt rtl_reset_counters_cond. :o/
>
> s/rtl8169_reset_counters/rtl8169_update_counters/g
>
> The code is right.
Please resubmit with fixed commit log messages, thanks!
next prev parent reply other threads:[~2015-09-07 7:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 12:18 [PATCH net 0/3] r8169: fix sleepable allocation during netdevice stats retrieval romieu
2015-09-05 12:18 ` [PATCH net 1/3] r8169: decouple the counters data and the device private area romieu
2015-09-06 10:38 ` Corinna Vinschen
2015-09-05 12:18 ` [PATCH net 2/3] r8169: move rtl_reset_counters_cond before the hardware counters helpers romieu
2015-09-05 12:18 ` [PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area romieu
2015-09-06 10:37 ` Corinna Vinschen
2015-09-06 20:21 ` Francois Romieu
2015-09-07 7:05 ` David Miller [this message]
2015-09-07 9:29 ` Corinna Vinschen
2015-09-08 0:00 ` David Miller
2015-09-08 8:05 ` Corinna Vinschen
2015-09-07 14:44 ` Corinna Vinschen
2015-09-07 21:52 ` Francois Romieu
2015-09-08 0:02 ` Francois Romieu
2015-09-08 20:23 ` Corinna Vinschen
2015-09-08 23:27 ` Francois Romieu
2015-09-09 9:00 ` Corinna Vinschen
2015-09-08 8:09 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907.000530.2280325695730676502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pomidorabelisima@gmail.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).