From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <netdev@vger.kernel.org>
Subject: Re: IPv6 xfrm GSO fragmentation bug
Date: Mon, 7 Sep 2015 12:00:45 +0200 [thread overview]
Message-ID: <20150907100044.GH25499@secunet.com> (raw)
In-Reply-To: <20150904052106.GA5689@gondor.apana.org.au>
On Fri, Sep 04, 2015 at 01:21:06PM +0800, Herbert Xu wrote:
> On Mon, Aug 31, 2015 at 03:35:26PM +0800, Herbert Xu wrote:
> >
> > I see where the bug came from. Indeed IPv6 does do fragmentation
> > but only for tunnel mode. While your patch added a check that also
> > affected transport mode. So in addition to the GSO fix we should
> > also make the MTU check conditional to tunnel mode.
>
> Here is the patch:
>
> ---8<---
> ipv6: Fix IPsec pre-encap fragmentation check
>
> The IPv6 IPsec pre-encap path performs fragmentation for tunnel-mode
> packets. That is, we perform fragmentation pre-encap rather than
> post-encap.
>
> A check was added later to ensure that proper MTU information is
> passed back for locally generated traffic. Unfortunately this
> check was performed on all IPsec packets, including transport-mode
> packets.
>
> What's more, the check failed to take GSO into account.
>
> The end result is that transport-mode GSO packets get dropped at
> the check.
>
> This patch fixes it by moving the tunnel mode check forward as well
> as adding the GSO check.
>
> Fixes: dd767856a36e ("xfrm6: Don't call icmpv6_send on local error")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to the ipsec tree, thanks Herbert!
prev parent reply other threads:[~2015-09-07 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 8:24 IPv6 xfrm GSO fragmentation bug Herbert Xu
2015-08-31 7:19 ` Steffen Klassert
2015-08-31 7:35 ` Herbert Xu
2015-09-04 5:21 ` Herbert Xu
2015-09-07 10:00 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907100044.GH25499@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).