From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, shm@cumulusnetworks.com, tom@herbertland.com
Subject: Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg
Date: Tue, 08 Sep 2015 13:28:55 -0700 (PDT) [thread overview]
Message-ID: <20150908.132855.1931912800434042661.davem@davemloft.net> (raw)
In-Reply-To: <55E4BCBE.4070900@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Mon, 31 Aug 2015 14:44:46 -0600
> If anything I should be going straight to fib_table_lookup in the VRF
> driver for this new lookup to get the source address. It knows the
> exact table that should be used and hence can avoid the rules walk +
> local table miss which happens using the ip_route_xxxxx functions as
> well as the rth lookup/create which is not needed here.
Definitely if this is the case you should do a direct fib_table_lookup().
prev parent reply other threads:[~2015-09-08 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 16:29 [PATCH net-next] net: Remove VRF change to udp_sendmsg David Ahern
2015-08-31 17:02 ` Tom Herbert
2015-08-31 17:05 ` David Ahern
2015-08-31 17:22 ` Tom Herbert
2015-08-31 17:40 ` David Ahern
2015-08-31 17:58 ` Tom Herbert
2015-08-31 17:49 ` David Ahern
2015-08-31 19:44 ` David Miller
2015-08-31 20:44 ` David Ahern
2015-09-08 20:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908.132855.1931912800434042661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).