From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH v3] net: ipv6: use common fib_default_rule_pref
Date: Wed, 09 Sep 2015 14:22:12 -0700 (PDT)
Message-ID: <20150909.142212.1136433147380661879.davem@davemloft.net>
References: <20150909114537.GP7029@orbit.nwl.cc>
	<1441801256-12551-1-git-send-email-phil@nwl.cc>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tgraf@suug.ch
To: phil@nwl.cc
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:35061 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752066AbbIIVWN (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 9 Sep 2015 17:22:13 -0400
In-Reply-To: <1441801256-12551-1-git-send-email-phil@nwl.cc>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Phil Sutter <phil@nwl.cc>
Date: Wed,  9 Sep 2015 14:20:56 +0200

> This switches IPv6 policy routing to use the shared
> fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
> multicast routing for IPv4 as well as IPv6.
> 
> The motivation for this patch is a complaint about iproute2 behaving
> inconsistent between IPv4 and IPv6 when adding policy rules: Formerly,
> IPv6 rules were assigned a fixed priority of 0x3FFF whereas for IPv4 the
> assigned priority value was decreased with each rule added.
> 
> Since then all users of the default_pref field have been converted to
> assign the generic function fib_default_rule_pref(), fib_nl_newrule()
> may just use it directly instead. Therefore get rid of the function
> pointer altogether and make fib_default_rule_pref() static, as it's not
> used outside fib_rules.c anymore.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

This looks a lot better, applied, thanks.