From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg
Date: Wed, 09 Sep 2015 20:20:26 -0700 (PDT) [thread overview]
Message-ID: <20150909.202026.215174674574675091.davem@davemloft.net> (raw)
In-Reply-To: <CALx6S35Fwu5QsR-W=0LVzvZv_PGqbV3TGR9T5YRU65QCY0OgzQ@mail.gmail.com>
From: Tom Herbert <tom@herbertland.com>
Date: Wed, 9 Sep 2015 17:51:19 -0700
> Consider that ip_local_out_sk calls netfilter NF_INET_LOCAL_OUT hook
> before dst->output, so then netfilter would start seeing packets
> with zero source address???
I have to agree with Tom here, this is fatal.
next prev parent reply other threads:[~2015-09-10 3:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 21:57 [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key David Ahern
2015-09-09 21:57 ` [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg David Ahern
2015-09-10 0:04 ` Tom Herbert
2015-09-10 0:23 ` David Ahern
2015-09-10 0:51 ` Tom Herbert
2015-09-10 1:10 ` David Ahern
2015-09-10 3:20 ` David Miller [this message]
2015-09-10 3:32 ` David Ahern
2015-09-09 22:56 ` [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key David Ahern
2015-09-10 0:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909.202026.215174674574675091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).