From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: roopa@cumulusnetworks.com, netdev@vger.kernel.org,
raghavendra.kt@linux.vnet.ibm.com
Subject: Re: IFLA_INET6_[ICMP6]STATS
Date: Thu, 10 Sep 2015 10:13:03 -0700 (PDT) [thread overview]
Message-ID: <20150910.101303.1945782677465930122.davem@davemloft.net> (raw)
In-Reply-To: <20150910154819.GL20544@oracle.com>
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 10 Sep 2015 11:48:19 -0400
> On (09/10/15 08:43), roopa wrote:
>> If you decide to use a flag, there is IFLA_EXT_MASK which is used to
>> specify such filters from userspace today.
>>
>> /* New extended info filters for IFLA_EXT_MASK */
>> #define RTEXT_FILTER_VF (1 << 0)
>> #define RTEXT_FILTER_BRVLAN (1 << 1)
>> #define RTEXT_FILTER_BRVLAN_COMPRESSED (1 << 2)
>
> I was actually going to use a NLM_F* flag, which is what
> I thought Dave as suggesting (seems a bit simpler
> than IFLA_EXT_MASK).
I don't think using such a generic netlink flag works best, the
IFLA_EXT_MASK is definitely more suitable.
next prev parent reply other threads:[~2015-09-10 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 21:34 IFLA_INET6_[ICMP6]STATS Sowmini Varadhan
2015-09-09 21:43 ` IFLA_INET6_[ICMP6]STATS David Miller
2015-09-09 21:45 ` IFLA_INET6_[ICMP6]STATS Sowmini Varadhan
2015-09-10 15:43 ` IFLA_INET6_[ICMP6]STATS roopa
2015-09-10 15:48 ` IFLA_INET6_[ICMP6]STATS Sowmini Varadhan
2015-09-10 17:13 ` David Miller [this message]
2015-09-10 17:16 ` IFLA_INET6_[ICMP6]STATS Sowmini Varadhan
2015-09-10 17:20 ` IFLA_INET6_[ICMP6]STATS David Miller
2015-09-10 15:19 ` IFLA_INET6_[ICMP6]STATS Raghavendra K T
2015-09-09 23:00 ` IFLA_INET6_[ICMP6]STATS Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910.101303.1945782677465930122.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=roopa@cumulusnetworks.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).