From: Corinna Vinschen <vinschen@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com,
pomidorabelisima@gmail.com, konrad@kernel.org,
linux-kernel@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH v2] r8169: Fix sleeping function called during get_stats64
Date: Thu, 10 Sep 2015 10:35:54 +0200 [thread overview]
Message-ID: <20150910083554.GA19486@calimero.vinschen.de> (raw)
In-Reply-To: <20150909.203147.2009094422078807401.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Sep 9 20:31, David Miller wrote:
> From: Corinna Vinschen <vinschen@redhat.com>
> Date: Wed, 9 Sep 2015 23:16:40 +0200
>
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031
> > Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8
> >
> > Based on the discussion starting at
> > http://www.spinics.net/lists/netdev/msg342193.html
> >
> > Tested locally on RTL8168evl/8111evl with various concurrent processes
> > accessing /proc/net/dev while changing the link state as well as
> > removing/reloading the r8169 module.
> >
> > Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
>
> Please address Francois's minor feedback, camelcase drives me nuts
> too FWIW :-)
Haha, with pleasure. I don't like them much either. I just used
them to align to the original code, which uses camel back for the
rx/tx descriptor ring buffers allocated the same way.
I'll send a v3 in a minute which fixes all of Francois points.
Thanks,
Corinna
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-09-10 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 21:16 [PATCH v2] r8169: Fix sleeping function called during get_stats64 Corinna Vinschen
2015-09-09 22:28 ` Francois Romieu
2015-09-10 3:31 ` David Miller
2015-09-10 8:35 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910083554.GA19486@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=davem@davemloft.net \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pomidorabelisima@gmail.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).