Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, y2038@lists.linaro.org,
	Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2x: use ktime_get_seconds() for timestamp
Date: Fri, 11 Sep 2015 15:03:22 -0700 (PDT)	[thread overview]
Message-ID: <20150911.150322.1083790165932796949.davem@davemloft.net> (raw)
In-Reply-To: <2387233.xmDni0GXyg@wuerfel>

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 11 Sep 2015 11:33:01 +0200

> commit c48f350ff5e7 "bnx2x: Add MFW dump support" added the
> bnx2x_update_mfw_dump() function that reads the current time and stores
> it in a 32-bit field that gets passed into a buffer in a fixed format.
> 
> This is potentially broken when the epoch overflows in 2038, and
> otherwise overflows in 2106. As we're trying to avoid uses of
> struct timeval for this reason, I noticed the addition of this
> function, and tried to rewrite it in a way that is more explicit
> about the overflow and that will keep working once we deprecate
> struct timeval.
> 
> I assume that it is not possible to change the ABI any more, otherwise
> we should try to use a 64-bit field for the seconds right away.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

      parent reply	other threads:[~2015-09-11 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  9:33 [PATCH] bnx2x: use ktime_get_seconds() for timestamp Arnd Bergmann
2015-09-11 10:29 ` Yuval Mintz
2015-09-11 22:03 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911.150322.1083790165932796949.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Ariel.Elior@qlogic.com \
    --cc=Yuval.Mintz@qlogic.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox