From: David Miller <davem@davemloft.net>
To: linus.luessing@c0d3.blue
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, tobias.powalowski@googlemail.com
Subject: Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing
Date: Fri, 11 Sep 2015 15:09:04 -0700 (PDT) [thread overview]
Message-ID: <20150911.150904.2037048001164493906.davem@davemloft.net> (raw)
In-Reply-To: <1441989588-26312-1-git-send-email-linus.luessing@c0d3.blue>
From: Linus Lüssing <linus.luessing@c0d3.blue>
Date: Fri, 11 Sep 2015 18:39:48 +0200
> With the newly introduced helper functions the skb pulling is hidden in
> the checksumming function - and undone before returning to the caller.
>
> The IGMPv3 and MLDv2 report parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header,
> breaking the message parsing and creating packet loss.
>
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
>
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Tobias Powalowski <tobias.powalowski@googlemail.com>
> Tested-by: Tobias Powalowski <tobias.powalowski@googlemail.com>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
There were many serious regressions introduced by that commit, I'm
extremely disappointed.
Patch applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-09-11 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 16:39 [PATCH net] bridge: fix igmpv3 / mldv2 report parsing Linus Lüssing
2015-09-11 22:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911.150904.2037048001164493906.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias.powalowski@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).