* [PATCH net] openvswitch: Fix dependency on IPv6 defrag.
@ 2015-09-11 22:01 Joe Stringer
2015-09-11 22:11 ` Pravin Shelar
2015-09-11 22:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Joe Stringer @ 2015-09-11 22:01 UTC (permalink / raw)
To: pshelar, netdev; +Cc: linux-kernel
When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and
OPENVSWITCH is built-in, the following build error would occur:
net/built-in.o: In function `ovs_ct_execute':
(.text+0x10f587): undefined reference to `nf_ct_frag6_gather'
Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Joe Stringer <joestringer@nicira.com>
---
net/openvswitch/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig
index 2a071f4..d143aa9 100644
--- a/net/openvswitch/Kconfig
+++ b/net/openvswitch/Kconfig
@@ -5,7 +5,8 @@
config OPENVSWITCH
tristate "Open vSwitch"
depends on INET
- depends on (!NF_CONNTRACK || NF_CONNTRACK)
+ depends on !NF_CONNTRACK || \
+ (NF_CONNTRACK && (!NF_DEFRAG_IPV6 || NF_DEFRAG_IPV6))
select LIBCRC32C
select MPLS
select NET_MPLS_GSO
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] openvswitch: Fix dependency on IPv6 defrag.
2015-09-11 22:01 [PATCH net] openvswitch: Fix dependency on IPv6 defrag Joe Stringer
@ 2015-09-11 22:11 ` Pravin Shelar
2015-09-11 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pravin Shelar @ 2015-09-11 22:11 UTC (permalink / raw)
To: Joe Stringer; +Cc: netdev, LKML
On Fri, Sep 11, 2015 at 3:01 PM, Joe Stringer <joestringer@nicira.com> wrote:
> When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and
> OPENVSWITCH is built-in, the following build error would occur:
>
> net/built-in.o: In function `ovs_ct_execute':
> (.text+0x10f587): undefined reference to `nf_ct_frag6_gather'
>
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Looks good
Acked-by: Pravin B Shelar <pshelar@nicira.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] openvswitch: Fix dependency on IPv6 defrag.
2015-09-11 22:01 [PATCH net] openvswitch: Fix dependency on IPv6 defrag Joe Stringer
2015-09-11 22:11 ` Pravin Shelar
@ 2015-09-11 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-09-11 22:39 UTC (permalink / raw)
To: joestringer; +Cc: pshelar, netdev, linux-kernel
From: Joe Stringer <joestringer@nicira.com>
Date: Fri, 11 Sep 2015 15:01:16 -0700
> When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and
> OPENVSWITCH is built-in, the following build error would occur:
>
> net/built-in.o: In function `ovs_ct_execute':
> (.text+0x10f587): undefined reference to `nf_ct_frag6_gather'
>
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-11 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-11 22:01 [PATCH net] openvswitch: Fix dependency on IPv6 defrag Joe Stringer
2015-09-11 22:11 ` Pravin Shelar
2015-09-11 22:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).