netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kafai@fb.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
	hannes@stressinduktion.org, kernel-team@fb.com
Subject: Re: [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel
Date: Mon, 14 Sep 2015 19:56:37 -0700 (PDT)	[thread overview]
Message-ID: <20150914.195637.558611773755031925.davem@davemloft.net> (raw)
In-Reply-To: <20150914.194925.1193918139295619388.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Mon, 14 Sep 2015 19:49:25 -0700 (PDT)

> Series applied, thanks Martin.

Actually, reverted, this doesn't even compile :-/

In file included from include/linux/srcu.h:33:0,
                 from include/linux/notifier.h:15,
                 from include/linux/memory_hotplug.h:6,
                 from include/linux/mmzone.h:812,
                 from include/linux/gfp.h:5,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from net/ipv6/ip6_tunnel.c:23:
net/ipv6/ip6_tunnel.c: In function ‘ip6_tnl_per_cpu_dst_set’:
net/ipv6/ip6_tunnel.c:135:35: error: invalid type argument of ‘->’ (have ‘seqlock_t’)
        lockdep_is_held(&idst->lock->lock)));
                                   ^
include/linux/rcupdate.h:569:52: note: in definition of macro ‘RCU_LOCKDEP_WARN’
   if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \
                                                    ^
include/linux/rcupdate.h:787:2: note: in expansion of macro ‘__rcu_dereference_protected’
  __rcu_dereference_protected((p), (c), __rcu)
  ^
net/ipv6/ip6_tunnel.c:133:14: note: in expansion of macro ‘rcu_dereference_protected’
  dst_release(rcu_dereference_protected(
              ^
net/ipv6/ip6_tunnel.c:135:8: note: in expansion of macro ‘lockdep_is_held’
        lockdep_is_held(&idst->lock->lock)));
        ^

  reply	other threads:[~2015-09-15  2:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 18:06 [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel Martin KaFai Lau
2015-09-11 18:06 ` [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes Martin KaFai Lau
2015-09-11 22:30   ` David Miller
2015-09-11 23:20     ` Martin KaFai Lau
2015-09-11 23:32       ` David Miller
2015-09-11 18:06 ` [PATCH v3 net 2/5] ipv6: Rename the dst_cache helper functions in ip6_tunnel Martin KaFai Lau
2015-09-11 18:06 ` [PATCH v3 net 3/5] ipv6: Fix dst_entry refcnt bugs " Martin KaFai Lau
2015-09-11 18:06 ` [PATCH v3 net 4/5] ipv6: Avoid double dst_free Martin KaFai Lau
2015-09-11 18:06 ` [PATCH v3 net 5/5] ipv6: Replace spinlock with seqlock and rcu in ip6_tunnel Martin KaFai Lau
2015-09-15  2:49 ` [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs " David Miller
2015-09-15  2:56   ` David Miller [this message]
2015-09-15 18:16     ` Martin KaFai Lau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914.195637.558611773755031925.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).