Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

[Viresh Kumar <viresh.kumar@linaro.org>]

On 14-09-15, 17:39, Arnd Bergmann wrote:
> On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
> > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
> > index b4c216bab22b..bea8e425a8de 100644
> > --- a/drivers/acpi/ec_sys.c
> > +++ b/drivers/acpi/ec_sys.c
> > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
> >  	if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> >  		goto error;
> >  	if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > -				 (u32 *)&first_ec->global_lock))
> > +				 &first_ec->global_lock))
> >  		goto error;
> >  
> >  	if (write_support)
> 
> This one might need a separate patch that can be backported to stable, as
> the original code is already broken on big-endian 64-bit machines:
> global_lock is 'unsigned long'.

Hmmm, so you suggest a single patch that will do s/unsigned long/u32
and that will be followed with this patch (almost) as is. Right?

Also, regarding the stable thing, we will surely not be able to
backport it straight away. But we should get it backported for sure.

@Greg: What all kernel versions you want this to be backported for?

-- 
viresh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>