From: David Miller <davem@davemloft.net>
To: alexei.starovoitov@gmail.com
Cc: cristos@vipserv.org, ebiederm@xmission.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] Net: core: sock.c coding style fixes
Date: Tue, 15 Sep 2015 11:53:58 -0700 (PDT) [thread overview]
Message-ID: <20150915.115358.27550892434513423.davem@davemloft.net> (raw)
In-Reply-To: <20150915184346.GA7817@Alexeis-MacBook-Pro-2.local>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Tue, 15 Sep 2015 11:43:49 -0700
> imo it makes sense to fix coding style only if nearby lines are
> affected by meaningful changes.
> Just blank rewrites like these are more harmful than useful.
> They distort git blame, make backporting harder, etc.
+1
next prev parent reply other threads:[~2015-09-15 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 17:58 [PATCH] Net: core: sock.c coding style fixes Krzysztof Majzerowicz-Jaszcz
2015-09-15 18:22 ` Eric W. Biederman
2015-09-15 18:36 ` Krzysztof Majzerowicz-Jaszcz
2015-09-15 18:43 ` Alexei Starovoitov
2015-09-15 18:53 ` David Miller [this message]
2015-09-15 19:11 ` Krzysztof Majzerowicz-Jaszcz
2015-09-15 18:53 ` David Miller
2015-09-15 19:08 ` Krzysztof Majzerowicz-Jaszcz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915.115358.27550892434513423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=cristos@vipserv.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).