netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fengguang.wu@intel.com
Cc: oneukum@suse.com, kbuild-all@01.org, netdev@vger.kernel.org
Subject: Re: [net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list
Date: Tue, 15 Sep 2015 13:25:38 -0700 (PDT)	[thread overview]
Message-ID: <20150915.132538.2065465403874989751.davem@davemloft.net> (raw)
In-Reply-To: <201509160313.6mZCFUqL%fengguang.wu@intel.com>

From: kbuild test robot <fengguang.wu@intel.com>
Date: Wed, 16 Sep 2015 03:56:14 +0800

> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/usb/gadget/function/u_serial.h:16:0,
>                     from drivers/usb/gadget/function/f_acm.c:23:
>>> include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list
>         int buflen);
>         ^
>>> include/linux/usb/cdc.h:47:5: warning: its scope is only this definition or declaration, which is probably not what you want

I'll fix this as follows:

====================
[PATCH] cdc: Fix build warning.

   In file included from drivers/usb/gadget/function/u_serial.h:16:0,
                    from drivers/usb/gadget/function/f_acm.c:23:
>> include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list
        int buflen);
        ^
>> include/linux/usb/cdc.h:47:5: warning: its scope is only this definition or declaration, which is probably not what you want

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/linux/usb/cdc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/usb/cdc.h b/include/linux/usb/cdc.h
index cd8f2e1..959d0c8 100644
--- a/include/linux/usb/cdc.h
+++ b/include/linux/usb/cdc.h
@@ -40,7 +40,7 @@ struct usb_cdc_parsed_header {
 	bool phonet_magic_present;
 };
 
-
+struct usb_interface;
 int cdc_parse_cdc_header(struct usb_cdc_parsed_header *hdr,
 				struct usb_interface *intf,
 				u8 *buffer,
-- 
2.1.0

      reply	other threads:[~2015-09-15 20:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 19:56 [net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list kbuild test robot
2015-09-15 20:25 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915.132538.2065465403874989751.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).