From: David Miller <davem@davemloft.net>
To: Woojung.Huh@microchip.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] lan78xx: update to use phylib
Date: Tue, 15 Sep 2015 14:46:38 -0700 (PDT) [thread overview]
Message-ID: <20150915.144638.155213100283923532.davem@davemloft.net> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D557D9F@CHN-SV-EXMX02.mchp-main.com>
From: <Woojung.Huh@microchip.com>
Date: Thu, 10 Sep 2015 22:16:11 +0000
> @@ -1287,42 +1074,30 @@ static int lan78xx_set_wol(struct net_device *netdev,
> static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata)
> {
> struct lan78xx_net *dev = netdev_priv(net);
> + struct phy_device *phydev = net->phydev;
> int ret;
> u32 buf;
> - u32 adv, lpadv;
>
> ret = usb_autopm_get_interface(dev->intf);
> if (ret < 0)
> return ret;
>
> + ret = phy_ethtool_get_eee(phydev, edata);
> + if (ret)
> + return ret;
> +
You cannot return directly if phy_ethtool_get_eee() returns an error,
you must branch to the end of this function and properly perform
the usb_autopm_get_interface().
prev parent reply other threads:[~2015-09-15 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 22:16 [PATCH 3/5] lan78xx: update to use phylib Woojung.Huh
2015-09-15 21:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915.144638.155213100283923532.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Woojung.Huh@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).